Test both vectorized and nonvectorized readers in Parquet golden file tests #13890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huaxingao
reviewed
Aug 21, 2025
...c/test/java/org/apache/iceberg/spark/data/vectorized/parquet/TestParquetVectorizedReads.java
Show resolved
Hide resolved
huaxingao
reviewed
Aug 21, 2025
...c/test/java/org/apache/iceberg/spark/data/vectorized/parquet/TestParquetVectorizedReads.java
Outdated
Show resolved
Hide resolved
kevinjqliu
approved these changes
Aug 24, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM
vectorized uses assertRecordsMatch which reads with VectorizedSparkParquetReaders 👍
Contributor
|
Merged. Thanks @eric-maynard for the PR! Thanks @kevinjqliu for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13450 added new tests for specific Parquet encodings that leverage pre-baked files. However, that test currently only reads these using the nonvectorized reader. This PR updates that test to check each file's data using both the vectorized and nonvectorized readers. Only files that are supported by both readers are included for the time being.