Skip to content

Spark 4: Support Parquet dictionary encoded UUIDs #13573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amogh-jahagirdar merged 1 commit into from
Jul 16, 2025
Merged

Spark 4: Support Parquet dictionary encoded UUIDs #13573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...rk/src/main/java/org/apache/iceberg/spark/data/vectorized/ArrowVectorAccessorFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@
import java.nio.ByteBuffer;
import org.apache.arrow.memory.ArrowBuf;
import org.apache.arrow.vector.FixedSizeBinaryVector;
import org.apache.arrow.vector.IntVector;
import org.apache.arrow.vector.ValueVector;
import org.apache.arrow.vector.VarCharVector;
import org.apache.arrow.vector.complex.ListVector;
import org.apache.iceberg.arrow.vectorized.GenericArrowVectorAccessorFactory;
import org.apache.iceberg.util.UUIDUtil;
import org.apache.parquet.column.Dictionary;
import org.apache.spark.sql.types.Decimal;
import org.apache.spark.sql.vectorized.ArrowColumnVector;
import org.apache.spark.sql.vectorized.ColumnarArray;
Expand Down Expand Up @@ -81,6 +83,12 @@ public UTF8String ofRow(FixedSizeBinaryVector vector, int rowId) {
return UTF8String.fromString(UUIDUtil.convert(vector.get(rowId)).toString());
}

@Override
public UTF8String ofRow(IntVector offsetVector, Dictionary dictionary, int rowId) {
byte[] bytes = dictionary.decodeToBinary(offsetVector.get(rowId)).getBytes();
return UTF8String.fromString(UUIDUtil.convert(bytes).toString());
}

@Override
public UTF8String ofBytes(byte[] bytes) {
return UTF8String.fromBytes(bytes);
Expand Down
15 changes: 15 additions & 0 deletions ...est/java/org/apache/iceberg/spark/data/vectorized/parquet/TestParquetVectorizedReads.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,4 +329,19 @@ public void testUnsupportedReadsForParquetV2() throws Exception {
.hasMessageStartingWith("Cannot support vectorized reads for column")
.hasMessageEndingWith("Disable vectorized reads to read this table/file");
}

@Test
public void testUuidReads() throws Exception {
// Just one row to maintain dictionary encoding
int numRows = 1;
Schema schema = new Schema(optional(100, "uuid", Types.UUIDType.get()));

File dataFile = File.createTempFile("junit", null, temp.toFile());
assertThat(dataFile.delete()).as("Delete should succeed").isTrue();
Iterable<Record> data = generateData(schema, numRows, 0L, 0, IDENTITY);
try (FileAppender<Record> writer = getParquetV2Writer(schema, dataFile)) {
writer.addAll(data);
}
assertRecordsMatch(schema, numRows, data, dataFile, false, BATCH_SIZE);
}
}