Skip to content

Conversation

@liko9
Copy link
Contributor

@liko9 liko9 commented Jul 15, 2025

removes commons-beanutils from non-hive deps, bump version to 1.11.0 to resolve CVE when using hive

@liko9
Copy link
Contributor Author

liko9 commented Jul 15, 2025

resolves #13563

@ajantha-bhat ajantha-bhat added this to the Iceberg 1.10.0 milestone Jul 16, 2025
}
all {
exclude group: 'javax.activation', module: 'activation'
exclude group: 'commons-beanutils'
Copy link
Member

@ajantha-bhat ajantha-bhat Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The (compile) checkstyle fails because of this line. Do we really need to exclude it?

When we add exclude group: 'commons-beanutils' to our configurations.all block, we are instructing Gradle to prevent any version of commons-beanutils from being included in any configuration's classpath for that project. This includes the classpath that Gradle sets up for its own plugins, like the Checkstyle plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal here is to not include it when not building for hive. But I'll file a separate issue for that and work on that for a future release. We don't need these hadoop deps for the non-Hive build. I'll update my PR shortly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We should focus on fixing CVE for main distribution (not hive) first. As that is the plugin we are gonna upload to confluent repo.

@ajantha-bhat
Copy link
Member

I locally tried by just adding one line under existing resolutionStrategy and everything worked
force 'commons-beanutils:commons-beanutils:1.11.0'

Trivy also ran after that successfully.

test {
useJUnitPlatform()
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we revert the unnecessary white space change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@ajantha-bhat ajantha-bhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I don't think we have integration test for distributions. So, maybe someone can confirm it works fine with this change.
Maybe @bryanck.

Regarding CVE, I have verified that it doesn't exist after this.

@stevenzwu stevenzwu merged commit 41c0b17 into apache:main Jul 17, 2025
12 checks passed
@stevenzwu
Copy link
Contributor

thanks @liko9 for the fix and @ajantha-bhat @nandorKollar for the review

github-merge-queue bot pushed a commit to zipline-ai/chronon that referenced this pull request Sep 22, 2025
## Summary

- Upgrade to iceberg 1.10.0 to grab column
[stats](apache/iceberg#10659), and some CVE's:
[CVE](apache/iceberg#13561) (and parquet, avro
transitively), and
[BigQueryMetastoreCatalog](apache/iceberg#12808),
[Google Auth](apache/iceberg#13212).
- Column stats is the key feature here - we rely on extracting the
puffin files and grabbing stats metadata.

<img width="1342" height="461" alt="Screenshot 2025-09-20 at 4 30 35 PM"
src="https://github.com/user-attachments/assets/bc8eeb80-6ff7-4abe-8ffb-a0eebf48bc4e"
/>


## Checklist
- [ ] Added Unit Tests
- [ ] Covered by existing CI
- [ ] Integration tested
- [ ] Documentation update
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Per-partition, per-column statistics extraction with optional
persistence to a new data-quality metrics KV store; platform APIs can
produce a metrics-specific KV store.

* **Breaking Changes**
* Extraction API signatures and summary/key formats changed; thrift
summary shapes updated; config token renamed "groupbys" → "group_bys";
/api/summary-series now returns null.

* **Refactor**
* Large-scale test package reorganizations and import consolidations
across the codebase.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->

---------

Co-authored-by: thomaschow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants