End to end read support for int96 parquet timestamps #1323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 when tests are passing. |
Contributor
|
Merged! Thanks @gustavoatt! |
Contributor
Author
|
Thanks for the fast review Ryan! |
|
Thanks! |
aokolnychyi
pushed a commit
to aokolnychyi/iceberg
that referenced
this pull request
Aug 18, 2020
cmathiesen
pushed a commit
to ExpediaGroup/iceberg
that referenced
this pull request
Aug 19, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1138 (comment) by making sure that we can convert from
org.apache.parquet.schema.MessageTypetoorg.apache.iceberg.types.Type.The issue was occurring due to Iceberg not being able to map the
int96type to an Iceberg Timestamp. Also added an end to end test to verify that we can read through Iceberg API the imported parquet file.While doing this, I noticed that the Iceberg generic parquet reader was reading the timestamp as timestamp without timezone instead of a timestamp with timezone.
Testing
Improved our current unit-test to handle this issue
Reviewers
to: @rdblue
cc: @thesquelched @aokolnychyi