Avro: Fix pruning columns when a logical-map array's value type is nested#1321
Merged
rdblue merged 1 commit intoapache:masterfrom Aug 14, 2020
Merged
Avro: Fix pruning columns when a logical-map array's value type is nested#1321rdblue merged 1 commit intoapache:masterfrom
rdblue merged 1 commit intoapache:masterfrom
Conversation
rdsr
reviewed
Aug 12, 2020
rdblue
reviewed
Aug 14, 2020
core/src/test/java/org/apache/iceberg/avro/TestAvroReadProjection.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Aug 14, 2020
core/src/test/java/org/apache/iceberg/avro/TestAvroReadProjection.java
Outdated
Show resolved
Hide resolved
…sted E.g., map(long, list<long>)
aokolnychyi
pushed a commit
to aokolnychyi/iceberg
that referenced
this pull request
Aug 18, 2020
cmathiesen
pushed a commit
to ExpediaGroup/iceberg
that referenced
this pull request
Aug 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a unit test which fails without the change
Consider type
map(long, list<long>)(a logical-map array in Iceberg-Avro) and a full projection.In
GetProjectedIds::map, the key id and value id won't be added if the value type is nested.Missing the key id can pose a problem in
PruneColumns::array, since the array's child record's key field will be omitted.