Spark 3.4: streaming-skip-overwrite-snapshots fix #13168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@singhpk234 @huaxingao I discovered that |
wypoon
commented
May 28, 2025
| Snapshot nextValid = nextValidSnapshot(curSnapshot); | ||
| if (nextValid == null) { | ||
| // nextValid implies all the remaining snapshots should be skipped. | ||
| break; |
Contributor
Author
There was a problem hiding this comment.
In the original, there was a
shouldContinueReading = false;
before the break, but that was removed as unnecessary by afda8be.
singhpk234
approved these changes
May 28, 2025
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, thanks @wypoon !
huaxingao
approved these changes
May 28, 2025
Contributor
|
Merged. Thanks @wypoon for the PR! Thanks @singhpk234 for the review! |
devendra-nr
pushed a commit
to devendra-nr/iceberg
that referenced
this pull request
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #8980, authored by @cccs-jc.