Skip to content

Conversation

@wypoon
Copy link
Contributor

@wypoon wypoon commented May 19, 2025

Use the ReadLimit passed in to SparkMicroBatchStream::latestOffset(Offset, ReadLimit). In testing this, a bug was found in SparkMicroBatchStream::getDefaultReadLimit() and fixed.

This is a forward port of #12260.

@wypoon
Copy link
Contributor Author

wypoon commented May 19, 2025

@huaxingao this is a clean forward port.

Copy link
Contributor

@singhpk234 singhpk234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huaxingao huaxingao merged commit 1911c94 into apache:main May 21, 2025
27 checks passed
@huaxingao
Copy link
Contributor

Merged. Thanks @wypoon for the PR! Thanks @singhpk234 for reviewing!

devendra-nr pushed a commit to devendra-nr/iceberg that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants