-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Parquet: Refactor parquet schema handling for variant type #12916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f32c68c to
554216e
Compare
parquet/src/test/java/org/apache/iceberg/parquet/TestVariantReaders.java
Outdated
Show resolved
Hide resolved
# Conflicts: # parquet/src/main/java/org/apache/iceberg/parquet/ParquetVariantUtil.java
aihuaxu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
parquet/src/test/java/org/apache/iceberg/parquet/TestVariantReaders.java
Outdated
Show resolved
Hide resolved
parquet/src/main/java/org/apache/iceberg/parquet/ParquetSchemaProducer.java
Outdated
Show resolved
Hide resolved
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
|
1 |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
Extract
ParquetSchemaProducerfromParquetVariantUtilto facilitate code reuse and future modifications.