Core: Ensure reactivated view version uses correct timestamp

[lliangyu-lin]

Description

• Fixes View's VersionLog uses wrong timestamp if ViewVersions are reused #12809
• Apply the fixes from fix: Update view version log timestamp for historical accuracy iceberg-rust#1218 by @c-thiel

[nastra]

I would slightly update/simplify this to

       // Use the timestamp from the view version if it was added in current set of changes;
       // otherwise, use the current system time. This handles cases where the view version
-      // was created in a past commit and is being re-activated.
+      // was set as current in the past and is being re-activated.
       boolean versionAddedInThisChange =
-          changes.stream()
-              .anyMatch(
-                  change ->
-                      change instanceof MetadataUpdate.AddViewVersion
-                          && ((MetadataUpdate.AddViewVersion) change).viewVersion().versionId()
-                              == newVersionId);
-
-      long timestamp =
-          versionAddedInThisChange ? version.timestampMillis() : System.currentTimeMillis();
+          changes(MetadataUpdate.AddViewVersion.class)
+              .anyMatch(added -> added.viewVersion().versionId() == newVersionId);

       this.historyEntry =
           ImmutableViewHistoryEntry.builder()
-              .timestampMillis(timestamp)
+              .timestampMillis(
+                  versionAddedInThisChange ? version.timestampMillis() : System.currentTimeMillis())
               .versionId(version.versionId())
               .build();

[lliangyu-lin]

@nastra Thanks for the review! I'll apply the comments and raise a revision.
But some concerns I have right now is that the change breaks existing unit tests like

iceberg/core/src/test/java/org/apache/iceberg/view/TestViewMetadataParser.java

Lines 218 to 239 in 9fc49e1

	ViewMetadata expectedViewMetadata =
	ViewMetadata.buildFrom(
	ViewMetadata.buildFrom(
	ViewMetadata.builder()
	.assignUUID("fa6506c3-7681-40c8-86dc-e36561f83385")
	.addSchema(TEST_SCHEMA)
	.addVersion(version1)
	.addVersion(version2)
	.setLocation("s3://bucket/test/location")
	.setProperties(
	ImmutableMap.of(
	"some-key",
	"some-value",
	ViewProperties.COMMENT,
	"some-comment"))
	.setCurrentVersionId(1)
	.upgradeFormatVersion(1)
	.build())
	.setCurrentVersionId(2)
	.build())
	.setMetadataLocation(metadataLocation)
	.build();

In .setCurrentVersionId(2), it's in different builder and have no local changes, causing the activation of view version to set to current timestamp even though version 2 never set as current before. And in the comment, we are trying to say only view version was set as current in the past will use current ts.

[nastra]

changing the unit test with the changes you have here in order to match the version-log that we compare against (we compare against a fixed timestamp defined in ValidViewMetadata.json) makes sense to me as this is a consequence of using the current time millis instead of the view version's time when setting the view version from 1 to 2 without actually adding view version 2 in the same builder.

[nastra]

LGTM, thanks @lliangyu-lin