Migrate Spark 3.4 TestBase-related remaining tests in actions #12579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Maybe the changes for |
tomtongue
force-pushed
the
spark3.4-testbase-remaining-actions
branch
from
3962c5d to
665adf9
Compare
Contributor
Author
|
@nastra Could you review this PR when you have time? |
nastra
reviewed
Mar 21, 2025
|
|
||
| assertThat(result.rewriteResults()).as("Should have 1 fileGroups").hasSize(1); | ||
| assertThat(result.rewrittenBytesCount()).isEqualTo(dataSizeBefore); | ||
| assertThat(result.rewriteResults()).as("Should have 1 fileGroups").hasSize(1); |
Contributor
There was a problem hiding this comment.
I think this was mistakenly removed and should be added back
nastra
reviewed
Mar 21, 2025
| StreamSupport.stream(result.orphanFileLocations().spliterator(), false) | ||
| .anyMatch(file -> file.contains("v1.metadata.json"))); | ||
| assertThat(result.orphanFileLocations()).as("Should delete 1 file").hasSize(1); | ||
| assertThat(StreamSupport.stream(result.orphanFileLocations().spliterator(), false)) |
Contributor
There was a problem hiding this comment.
did you mean to backport the change here without using StreamSupport?
Contributor
Author
There was a problem hiding this comment.
Oh yes, thanks so much for pointing this out. Let me fix.
Contributor
Author
|
Thanks for the review!! @nastra |
lliangyu-lin
pushed a commit
to lliangyu-lin/iceberg
that referenced
this pull request
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Spark 3.4 tests based on JUnit 4 to Junit5 with AssertJ style. This is related to #7160
This PR migrates the other tests in the
spark.actionspackage in Spark 3.4 into JUnit 5 with AssertJ. The following classes are included in this PR:TestRewriteDataFilesActionTestRewriteManifestsActionTestRewriteTablePathsAction(backporting from Spark: Improve assertions for better debuggability #12569)TestRemoveOrphanFilesActionandTestRemoveOrphanFilesAction3