Refactor the SparkOrcWriter by using OrcSchemaWithTypeVisitor#visit #1238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Rebase to fix the conflicts, and trigger the travis test. |
rdblue
reviewed
Jul 31, 2020
| return DoubleWriter.INSTANCE; | ||
| } | ||
|
|
||
| public static SparkOrcValueWriter byteArray() { |
Contributor
There was a problem hiding this comment.
Nit: this is the only one that isn't plural, byteArrays.
Contributor
|
+1 I think this looks good, but @rdsr or @shardulm94 may want to take a look also. |
Member
Author
|
Ping @rdsr @shardulm94 for reviewing. Thanks. |
Contributor
|
Thanks @openinx . Looking into it today |
rdsr
reviewed
Aug 5, 2020
cmathiesen
pushed a commit
to ExpediaGroup/iceberg
that referenced
this pull request
Aug 19, 2020
…pache#1238) * Refactor the SparkOrcWriter by using OrcSchemaWithTypeVisitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addressed the issues from #1236. Once patch
#1197get merged, I will do a git-rebase and it will only remain the spark orc writer changes.