Skip to content

[1.8.x] Parquet: Fix performance regression in reader init (#12305) #12338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nastra merged 1 commit into from
Feb 19, 2025
Merged

[1.8.x] Parquet: Fix performance regression in reader init (#12305) #12338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
import org.apache.parquet.avro.AvroWriteSupport;
import org.apache.parquet.column.ParquetProperties;
import org.apache.parquet.column.ParquetProperties.WriterVersion;
import org.apache.parquet.conf.PlainParquetConfiguration;
import org.apache.parquet.crypto.FileDecryptionProperties;
import org.apache.parquet.crypto.FileEncryptionProperties;
import org.apache.parquet.hadoop.ParquetFileReader;
Expand Down Expand Up @@ -1206,7 +1207,7 @@ public <D> CloseableIterable<D> build() {
}
optionsBuilder = HadoopReadOptions.builder(conf);
} else {
optionsBuilder = ParquetReadOptions.builder();
optionsBuilder = ParquetReadOptions.builder(new PlainParquetConfiguration());
}

for (Map.Entry<String, String> entry : properties.entrySet()) {
Expand Down Expand Up @@ -1275,7 +1276,9 @@ public <D> CloseableIterable<D> build() {
// TODO: should not need to get the schema to push down before opening the file.
// Parquet should allow setting a filter inside its read support
ParquetReadOptions decryptOptions =
ParquetReadOptions.builder().withDecryption(fileDecryptionProperties).build();
ParquetReadOptions.builder(new PlainParquetConfiguration())
.withDecryption(fileDecryptionProperties)
.build();
MessageType type;
try (ParquetFileReader schemaReader =
ParquetFileReader.open(ParquetIO.file(file), decryptOptions)) {
Expand Down
Loading