Skip to content

API: Fix TestInclusiveMetricsEvaluator notStartsWith tests #12303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 1 commit into from
Feb 18, 2025
Merged

API: Fix TestInclusiveMetricsEvaluator notStartsWith tests #12303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,9 @@ public class TestInclusiveMetricsEvaluator {
Row.of(),
50,
// any value counts, including nulls
ImmutableMap.of(3, 20L),
ImmutableMap.of(3, 50L),
// null value counts
ImmutableMap.of(3, 2L),
ImmutableMap.of(3, 0L),
// nan value counts
null,
// lower bounds
Expand All @@ -145,9 +145,9 @@ public class TestInclusiveMetricsEvaluator {
Row.of(),
50,
// any value counts, including nulls
ImmutableMap.of(3, 20L),
ImmutableMap.of(3, 50L),
// null value counts
ImmutableMap.of(3, 2L),
ImmutableMap.of(3, 0L),
// nan value counts
null,
// lower bounds
Expand All @@ -161,16 +161,32 @@ public class TestInclusiveMetricsEvaluator {
Row.of(),
50,
// any value counts, including nulls
ImmutableMap.of(3, 20L),
ImmutableMap.of(3, 50L),
// null value counts
ImmutableMap.of(3, 2L),
ImmutableMap.of(3, 0L),
// nan value counts
null,
// lower bounds
ImmutableMap.of(3, toByteBuffer(StringType.get(), "abc")),
// upper bounds
ImmutableMap.of(3, toByteBuffer(StringType.get(), "イロハニホヘト")));

private static final DataFile FILE_5 =
new TestDataFile(
"file_4.avro",
Row.of(),
50,
// any value counts, including nulls
ImmutableMap.of(3, 50L),
// null value counts
ImmutableMap.of(3, 0L),
// nan value counts
null,
// lower bounds
ImmutableMap.of(3, toByteBuffer(StringType.get(), "abc")),
// upper bounds
ImmutableMap.of(3, toByteBuffer(StringType.get(), "abcdefghi")));

@Test
public void testAllNulls() {
boolean shouldRead = new InclusiveMetricsEvaluator(SCHEMA, notNull("all_nulls")).eval(FILE);
Expand Down Expand Up @@ -731,6 +747,14 @@ public void testStringNotStartsWith() {
new InclusiveMetricsEvaluator(SCHEMA, notStartsWith("required", aboveMax), true)
.eval(FILE_4);
assertThat(shouldRead).as("Should read: range matches").isTrue();

shouldRead =
new InclusiveMetricsEvaluator(SCHEMA, notStartsWith("required", "abc"), true).eval(FILE_5);
assertThat(shouldRead).as("Should not read: all strings start with prefix").isFalse();

shouldRead =
new InclusiveMetricsEvaluator(SCHEMA, notStartsWith("required", "abcd"), true).eval(FILE_5);
assertThat(shouldRead).as("Should not read: lower shorter than prefix, cannot match").isTrue();
}

@Test
Expand Down