Skip to content

Spark 3.5: Fix job description of RewriteTablePathSparkAction #12282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szehon-ho merged 1 commit into from
Feb 17, 2025
Merged

Spark 3.5: Fix job description of RewriteTablePathSparkAction #12282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ private boolean versionInFilePath(String path, String version) {
}

private String jobDesc() {
if (startVersionName != null) {
if (startVersionName == null) {
Copy link
Member

@manuzhang manuzhang Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Can we add a UT?

Copy link
Contributor Author

@ebyhr ebyhr Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's overkill to me.

Copy link
Member

@szehon-ho szehon-ho Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I dont think we have too many tests asserting a message, Im fine without it as well.

Copy link
Member

@manuzhang manuzhang Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the current status, but I still believe we could have caught it with a UT.

return String.format(
"Replacing path prefixes '%s' with '%s' in the metadata files of table %s,"
+ "up to version '%s'.",
Expand Down