Skip to content

Minor: update Learn More to point to spark quickstart #12272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RussellSpitzer merged 1 commit into from
Feb 14, 2025
Merged

Minor: update Learn More to point to spark quickstart #12272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/docs/about.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Iceberg is a high-performance format for huge analytic tables. Iceberg brings th
<div class="button-box">
<ul class="list-inline intro-social-buttons">
<li>
<a href="/getting-started" class="btn btn-default btn-lg">
<a href="/spark-quickstart" class="btn btn-default btn-lg">
Copy link
Contributor

@Fokko Fokko Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting a PR here @danicafine. When I see a button with Learn more, I expect more docs, how about linking to the Docs introduction: https://iceberg.apache.org/docs/latest/

Suggested change
<a href="/spark-quickstart" class="btn btn-default btn-lg">
<a href="/docs/latest/" class="btn btn-default btn-lg">

Thoughts?

Copy link
Contributor

@Fokko Fokko Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I now see @RussellSpitzer's comment: #12265 (comment)

I'm fine with both :)

Copy link
Member

@RussellSpitzer RussellSpitzer Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it used to go to the generic quickstart before we split it I believe. Either is also fine with me but I think I slightly prefer the quickstart.

<span class="network-name">Learn More</span>
</a>
</li>
Expand Down