Skip to content

Conversation

@rdblue
Copy link
Contributor

@rdblue rdblue commented Feb 11, 2025

This is a follow up to #12211. While adding support for default values in UpdateSchema, many of the changes were to use the NestedField builder's copy constructor, from(NestedField), so that field defaults are not dropped. Dropping defaults is easy to do when using the of factory method that was previously used to copy fields.

This PR deprecates that factory method and removes deprecated uses of NestedField methods.

Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdblue I believe you meant to also push changes that include a builder() method. Also I think it would be good to update all of the usages in SchemaUpdate to the non-deprecated methods

@rdblue
Copy link
Contributor Author

rdblue commented Feb 12, 2025

Also I think it would be good to update all of the usages in SchemaUpdate to the non-deprecated methods

That's done in #12211. This will be rebased and merged after that one goes in.

@nastra
Copy link
Contributor

nastra commented Feb 14, 2025

LGTM, thanks @rdblue

@nastra nastra merged commit b78d36a into apache:main Feb 14, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants