Update LICENSE/NOTICE in flink-runtime jar files #12188
Conversation
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
I checked the jars as a sanity check for 1.18 and 1.19 for the discussion points we had on the original PR and I also think the same changes that apply for 1.20 apply for 1.18/1.19. The difference between the versions is just the specific Flink version differences which are all compile only.
| This binary artifact contains Airlift Slice. | ||
|
|
||
| Copyright: 2013-2020 Slice authors. | ||
| Home page: https://github.com/airlift/slice | ||
| License: http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| -------------------------------------------------------------------------------- |
There was a problem hiding this comment.
I think removing Airlift Slice from our License is good, it's not in our JAR (which makes sense since Slice was removed as a dependency from Aircompressor a while back airlift/aircompressor#100) .
| This binary artifact contains Codehale Metrics. | ||
|
|
||
| Copyright: (c) 2010-2013 Coda Hale, Yammer.com, 2014-2021 Dropwizard Team | ||
| Home page: https://github.com/dropwizard/metrics | ||
| License: https://www.apache.org/licenses/LICENSE-2.0.html | ||
|
|
||
| -------------------------------------------------------------------------------- | ||
|
|
There was a problem hiding this comment.
I also agree with adding this, we do depend on these metrics IcebergStreamWriterMetrics does some sort of resevoir sampling which uses SlidingWindowReservoir from this package and i see classes from this dependency in the jar.
|
Thanks for double checking the 1.20 changes, @amogh-jahagirdar! |
3 participants
This PR:
LICENSE(I don't see it in any flink-runtime jar)LICENSEandNOTICEfrom 1.20 also apply