Remove deprecated OBJECT_STORE_PATH and WRITE_FOLDER_STORAGE_LOCATION
#12174
Conversation
…_LOCATION` Has been deprecated since 0.12.0
| dataLocation = properties.get(TableProperties.OBJECT_STORE_PATH); | ||
| if (dataLocation == null) { | ||
| dataLocation = properties.get(TableProperties.WRITE_FOLDER_STORAGE_LOCATION); | ||
| if (dataLocation == null) { | ||
| dataLocation = String.format("%s/data", tableLocation); | ||
| } | ||
| } | ||
| dataLocation = String.format("%s/data", tableLocation); |
There was a problem hiding this comment.
I enjoy remove deprecated method or config but it's always a bit risky. From a iceberg user perspective, if I had a running iceberg data pipeline, I might not ever going to change/move away from deprecated one.
So in a worst case scenario for a given table with OBJECT_STORE_PATH or WRITE_FOLDER_STORAGE_LOCATION is set and its value is not equal to WRITE_DATA_LOCATION, shall we abort the write to force user action?
I think current logic is ignoring the old table properties and directly write into default, I think it might be reasonable but want to know if this is intended. Maybe we can raise the awareness on dev list about the change?
There was a problem hiding this comment.
It has been deprecated for quite a while, but I'm happy to send out an email on the dev list.
And yes, there is some risk involved if you don't import the TableProperties.{OBJECT_STORE_PATH,WRITE_FOLDER_STORAGE_LOCATION}. This way you don't see the deprecation, and your code will still compile after the removal of the property. Let's hear what others think.
Fokko
changed the title
WRITE_METADATA_LOCATION and WRITE_FOLDER_STORAGE_LOCATIONOBJECT_STORE_PATH and WRITE_FOLDER_STORAGE_LOCATION
|
Closing this one in favor of #12315 |
4 participants
I was digging into this for PyIceberg, this has been deprecated since 0.12.0