Spark 3.5: Procedure to rewrite table path #11931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FYI @szehon-ho @flyrain @karuppayya @anuragmantri if you want to take a look |
karuppayya
reviewed
Jan 9, 2025
...ensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteTablePathProcedure.java
Show resolved
Hide resolved
...ensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteTablePathProcedure.java
Show resolved
Hide resolved
...ensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteTablePathProcedure.java
Show resolved
Hide resolved
Member
|
@dramaticlly would you mind updating doc as well? |
Contributor
Author
Yes @manuzhang , I plan to have a followup PR with spark procedure documentation once this is merged. |
nastra
reviewed
Jan 20, 2025
...ensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteTablePathProcedure.java
Outdated
Show resolved
Hide resolved
nastra
reviewed
Jan 20, 2025
...ensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteTablePathProcedure.java
Outdated
Show resolved
Hide resolved
szehon-ho
reviewed
Jan 22, 2025
Member
szehon-ho
left a comment
szehon-ho
left a comment
There was a problem hiding this comment.
Thanks @dramaticlly some more small comments, questions
.../v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteTablePathProcedure.java
Outdated
Show resolved
Hide resolved
.../v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteTablePathProcedure.java
Outdated
Show resolved
Hide resolved
...k/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java
Show resolved
Hide resolved
szehon-ho
reviewed
Jan 23, 2025
.../v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteTablePathProcedure.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
approved these changes
Jan 23, 2025
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Thanks @dramaticlly! just had some nits and a possible follow up that we could do but nothing that I consider blocking at the moment. I'll hold for other's feedback before merging
...ensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteTablePathProcedure.java
Show resolved
Hide resolved
.../v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteTablePathProcedure.java
Outdated
Show resolved
Hide resolved
.../v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteTablePathProcedure.java
Outdated
Show resolved
Hide resolved
nastra
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add spark procedure for rewrite table path