Spark: support statistics files in RewriteTablePath #11929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyrain
reviewed
Jan 8, 2025
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
Contributor
Author
|
Not stale, will rebase |
szehon-ho
reviewed
Feb 8, 2025
Member
szehon-ho
left a comment
szehon-ho
left a comment
There was a problem hiding this comment.
Sorry this slipped, this mostly looks good, just small subjective code suggestions.
...k/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java
Outdated
Show resolved
Hide resolved
...k/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java
Show resolved
Hide resolved
Check for partition stats
dramaticlly
force-pushed
the
copy-stats
branch
from
e58b461 to
b5a2981
Compare
szehon-ho
approved these changes
Feb 8, 2025
Member
|
Merged, thanks @dramaticlly ! and @flyrain for additional review! |
Contributor
Author
|
Thanks you @szehon-ho ! |
slfan1989
pushed a commit
to slfan1989/iceberg
that referenced
this pull request
Mar 19, 2025
slfan1989
added a commit
to slfan1989/iceberg
that referenced
this pull request
Mar 19, 2025
slfan1989
added a commit
to slfan1989/iceberg
that referenced
this pull request
Mar 23, 2025
nastra
pushed a commit
that referenced
this pull request
Mar 24, 2025
… procedure (#12006 #12172 #11929 #12282 #12569) (#12568) * [BackPort#12006] Core: Exclude deleted content file in RewriteTablePathUtil copy plan (#12006) * [BackPort#12172] Core: Fix RewriteTablePath Incremental Replication (#12172) * [BackPort#11929] Spark 3.5: Support Statistics Files in RewriteTablePath (#11929) * [BackPort#12282] Spark 3.5: Fix job description of RewriteTablePathSparkAction(#12282) * [BackPort#12569] Spark: Improve assertions for better debuggability (#12569)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statistics files are helpful to determine the NDV for each columns in a table and can be collected via engines like trino or spark
This patch help support table statistics files as part of rewrite table path spark action.
@szehon-ho @flyrain if you want to take a look