ORC: Use ConstantReader for identity partition columns #1191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
reviewed
Jul 10, 2020
| } | ||
|
|
||
| @Override | ||
| public C read(ColumnVector ignored, int ignoredRow) { |
Contributor
There was a problem hiding this comment.
Is ColumnVector still materialized? Is it possible to avoid reading that entirely?
Contributor
Author
There was a problem hiding this comment.
Yes, I guess we can do that by not asking ORC to project these columns. Let me give it a try.
Contributor
There was a problem hiding this comment.
That's going to be a bigger time savings and that's what we do for Parquet. We just drop it from the projection we pass down to the format.
rdblue
reviewed
Jul 10, 2020
Contributor
|
+1, just a minor issue. |
Contributor
Author
|
I think this code will be changed a bit in #1021 to handle not just constant columns but also metadata columns, since we would want to avoid materializing a |
aokolnychyi
pushed a commit
to aokolnychyi/iceberg
that referenced
this pull request
Aug 18, 2020
cmathiesen
pushed a commit
to ExpediaGroup/iceberg
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1056
cc: @rdsr Since you had worked on this initially