-
Notifications
You must be signed in to change notification settings - Fork 3k
Core: add variant type support #11831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 10 commits
b8f721f
9a07342
31b0ee3
82f654c
fcb3b67
50d1482
f53769b
93586e3
1d54ff4
9082cab
1472417
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,6 +33,6 @@ class PrimitiveHolder implements Serializable { | |
| } | ||
|
|
||
| Object readResolve() throws ObjectStreamException { | ||
| return Types.fromPrimitiveString(typeAsString); | ||
| return Types.fromTypeName(typeAsString); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is tested by
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The new type tests have been added in
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like the test for this is missing variant. |
||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.