-
Notifications
You must be signed in to change notification settings - Fork 3k
Flink: Add wrapper to adapt Row to StructLike #1175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
105 changes: 105 additions & 0 deletions
105
flink/src/main/java/org/apache/iceberg/flink/RowWrapper.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.iceberg.flink; | ||
|
|
||
| import java.lang.reflect.Array; | ||
| import java.nio.ByteBuffer; | ||
| import java.time.LocalDate; | ||
| import java.time.LocalDateTime; | ||
| import java.time.LocalTime; | ||
| import java.time.OffsetDateTime; | ||
| import org.apache.flink.types.Row; | ||
| import org.apache.iceberg.StructLike; | ||
| import org.apache.iceberg.types.Type; | ||
| import org.apache.iceberg.types.Types; | ||
| import org.apache.iceberg.util.DateTimeUtil; | ||
|
|
||
| class RowWrapper implements StructLike { | ||
|
|
||
| private final Type[] types; | ||
| private final PositionalGetter[] getters; | ||
| private Row row = null; | ||
|
|
||
| RowWrapper(Types.StructType type) { | ||
| int size = type.fields().size(); | ||
|
|
||
| types = (Type[]) Array.newInstance(Type.class, size); | ||
| for (int i = 0; i < size; i++) { | ||
| types[i] = type.fields().get(i).type(); | ||
| } | ||
|
|
||
| getters = (PositionalGetter[]) Array.newInstance(PositionalGetter.class, size); | ||
| for (int i = 0; i < size; i++) { | ||
| getters[i] = buildGetter(types[i]); | ||
| } | ||
| } | ||
|
|
||
| RowWrapper wrap(Row data) { | ||
| this.row = data; | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public int size() { | ||
| return types.length; | ||
| } | ||
|
|
||
| @Override | ||
| public <T> T get(int pos, Class<T> javaClass) { | ||
| if (row.getField(pos) == null) { | ||
| return null; | ||
| } else if (getters[pos] != null) { | ||
| return javaClass.cast(getters[pos].get(row, pos)); | ||
| } | ||
|
|
||
| return javaClass.cast(row.getField(pos)); | ||
| } | ||
|
|
||
| @Override | ||
| public <T> void set(int pos, T value) { | ||
| row.setField(pos, value); | ||
| } | ||
|
|
||
| private interface PositionalGetter<T> { | ||
| T get(Row row, int pos); | ||
| } | ||
|
|
||
| private static PositionalGetter buildGetter(Type type) { | ||
| switch (type.typeId()) { | ||
| case DATE: | ||
| return (r, pos) -> DateTimeUtil.daysFromDate((LocalDate) r.getField(pos)); | ||
| case TIME: | ||
| return (r, pos) -> DateTimeUtil.microsFromTime((LocalTime) r.getField(pos)); | ||
| case TIMESTAMP: | ||
| if (((Types.TimestampType) type).shouldAdjustToUTC()) { | ||
| return (r, pos) -> DateTimeUtil.microsFromTimestamptz((OffsetDateTime) r.getField(pos)); | ||
| } else { | ||
| return (r, pos) -> DateTimeUtil.microsFromTimestamp((LocalDateTime) r.getField(pos)); | ||
| } | ||
| case FIXED: | ||
| return (r, pos) -> ByteBuffer.wrap((byte[]) r.getField(pos)); | ||
| case STRUCT: | ||
| RowWrapper nestedWrapper = new RowWrapper((Types.StructType) type); | ||
| return (r, pos) -> nestedWrapper.wrap((Row) r.getField(pos)); | ||
| default: | ||
| return null; | ||
| } | ||
| } | ||
| } |
230 changes: 230 additions & 0 deletions
230
flink/src/test/java/org/apache/iceberg/flink/TestPartitionKey.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,230 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.iceberg.flink; | ||
|
|
||
| import java.nio.ByteBuffer; | ||
| import java.time.LocalDate; | ||
| import java.time.LocalDateTime; | ||
| import java.time.LocalTime; | ||
| import java.time.OffsetDateTime; | ||
| import java.util.List; | ||
| import org.apache.flink.types.Row; | ||
| import org.apache.iceberg.PartitionKey; | ||
| import org.apache.iceberg.PartitionSpec; | ||
| import org.apache.iceberg.Schema; | ||
| import org.apache.iceberg.flink.data.RandomData; | ||
| import org.apache.iceberg.relocated.com.google.common.collect.Lists; | ||
| import org.apache.iceberg.types.Type; | ||
| import org.apache.iceberg.types.Types; | ||
| import org.apache.iceberg.util.DateTimeUtil; | ||
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
|
|
||
| public class TestPartitionKey { | ||
|
|
||
| private static final Schema SCHEMA = new Schema( | ||
| Types.NestedField.optional(1, "id", Types.IntegerType.get()), | ||
| Types.NestedField.optional(2, "dateType", Types.DateType.get()), | ||
| Types.NestedField.optional(3, "timeType", Types.TimeType.get()), | ||
| Types.NestedField.optional(4, "timestampWithoutZone", Types.TimestampType.withoutZone()), | ||
| Types.NestedField.required(5, "timestampWithZone", Types.TimestampType.withZone()), | ||
| Types.NestedField.optional(6, "fixedType", Types.FixedType.ofLength(5)), | ||
| Types.NestedField.optional(7, "uuidType", Types.UUIDType.get()), | ||
| Types.NestedField.optional(8, "binaryType", Types.BinaryType.get()), | ||
| Types.NestedField.optional(9, "decimalType1", Types.DecimalType.of(3, 14)), | ||
| Types.NestedField.optional(10, "decimalType2", Types.DecimalType.of(10, 20)), | ||
| Types.NestedField.optional(11, "decimalType3", Types.DecimalType.of(38, 19)), | ||
| Types.NestedField.optional(12, "floatType", Types.FloatType.get()), | ||
| Types.NestedField.required(13, "doubleType", Types.DoubleType.get()) | ||
| ); | ||
|
|
||
| private static final String[] SUPPORTED_PRIMITIVES = new String[] { | ||
| "id", "dateType", "timeType", "timestampWithoutZone", "timestampWithZone", "fixedType", "uuidType", | ||
| "binaryType", "decimalType1", "decimalType2", "decimalType3", "floatType", "doubleType" | ||
| }; | ||
|
|
||
| private static final Schema NESTED_SCHEMA = new Schema( | ||
| Types.NestedField.required(1, "structType", Types.StructType.of( | ||
| Types.NestedField.optional(2, "innerStringType", Types.StringType.get()), | ||
| Types.NestedField.optional(3, "innerIntegerType", Types.IntegerType.get()) | ||
| )) | ||
| ); | ||
|
|
||
| @Test | ||
| public void testNullPartitionValue() { | ||
| Schema schema = new Schema( | ||
| Types.NestedField.optional(1, "id", Types.IntegerType.get()), | ||
| Types.NestedField.optional(2, "data", Types.StringType.get()) | ||
| ); | ||
|
|
||
| PartitionSpec spec = PartitionSpec.builderFor(schema) | ||
| .identity("data") | ||
| .build(); | ||
|
|
||
| List<Row> rows = Lists.newArrayList( | ||
| Row.of(1, "a"), | ||
| Row.of(2, "b"), | ||
| Row.of(3, null) | ||
| ); | ||
|
|
||
| RowWrapper rowWrapper = new RowWrapper(schema.asStruct()); | ||
|
|
||
| for (Row row : rows) { | ||
| PartitionKey partitionKey = new PartitionKey(spec, schema); | ||
| partitionKey.partition(rowWrapper.wrap(row)); | ||
| Assert.assertEquals(partitionKey.size(), 1); | ||
| Assert.assertEquals(partitionKey.get(0, String.class), row.getField(1)); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testPartitionWithOneNestedField() { | ||
| RowWrapper rowWrapper = new RowWrapper(NESTED_SCHEMA.asStruct()); | ||
| Iterable<Row> rows = RandomData.generate(NESTED_SCHEMA, 10, 1991); | ||
|
|
||
| PartitionSpec spec1 = PartitionSpec.builderFor(NESTED_SCHEMA) | ||
| .identity("structType.innerStringType") | ||
| .build(); | ||
| PartitionSpec spec2 = PartitionSpec.builderFor(NESTED_SCHEMA) | ||
| .identity("structType.innerIntegerType") | ||
| .build(); | ||
|
|
||
| for (Row row : rows) { | ||
| Row innerRow = (Row) row.getField(0); | ||
|
|
||
| PartitionKey partitionKey1 = new PartitionKey(spec1, NESTED_SCHEMA); | ||
| partitionKey1.partition(rowWrapper.wrap(row)); | ||
| Object innerStringValue = innerRow.getField(0); | ||
| Assert.assertEquals(partitionKey1.size(), 1); | ||
| Assert.assertEquals(partitionKey1.get(0, String.class), innerStringValue); | ||
|
|
||
| PartitionKey partitionKey2 = new PartitionKey(spec2, NESTED_SCHEMA); | ||
| partitionKey2.partition(rowWrapper.wrap(row)); | ||
| Object innerIntegerValue = innerRow.getField(1); | ||
| Assert.assertEquals(partitionKey2.size(), 1); | ||
| Assert.assertEquals(partitionKey2.get(0, Integer.class), innerIntegerValue); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testPartitionMultipleNestedField() { | ||
| RowWrapper rowWrapper = new RowWrapper(NESTED_SCHEMA.asStruct()); | ||
| Iterable<Row> rows = RandomData.generate(NESTED_SCHEMA, 10, 1992); | ||
|
|
||
| PartitionSpec spec1 = PartitionSpec.builderFor(NESTED_SCHEMA) | ||
| .identity("structType.innerIntegerType") | ||
| .identity("structType.innerStringType") | ||
| .build(); | ||
| PartitionSpec spec2 = PartitionSpec.builderFor(NESTED_SCHEMA) | ||
| .identity("structType.innerStringType") | ||
| .identity("structType.innerIntegerType") | ||
| .build(); | ||
|
|
||
| PartitionKey pk1 = new PartitionKey(spec1, NESTED_SCHEMA); | ||
| PartitionKey pk2 = new PartitionKey(spec2, NESTED_SCHEMA); | ||
|
|
||
| for (Row row : rows) { | ||
| Row innerRow = (Row) row.getField(0); | ||
|
|
||
| pk1.partition(rowWrapper.wrap(row)); | ||
| Assert.assertEquals(2, pk1.size()); | ||
| Assert.assertEquals(innerRow.getField(1), pk1.get(0, Integer.class)); | ||
| Assert.assertEquals(innerRow.getField(0), pk1.get(1, String.class)); | ||
|
|
||
| pk2.partition(rowWrapper.wrap(row)); | ||
| Assert.assertEquals(2, pk2.size()); | ||
| Assert.assertEquals(innerRow.getField(0), pk2.get(0, String.class)); | ||
| Assert.assertEquals(innerRow.getField(1), pk2.get(1, Integer.class)); | ||
| } | ||
| } | ||
|
|
||
| private static Object transform(Object value, Type type) { | ||
| if (value == null) { | ||
| return null; | ||
| } | ||
| switch (type.typeId()) { | ||
| case DATE: | ||
| return DateTimeUtil.daysFromDate((LocalDate) value); | ||
| case TIME: | ||
| return DateTimeUtil.microsFromTime((LocalTime) value); | ||
| case TIMESTAMP: | ||
| if (((Types.TimestampType) type).shouldAdjustToUTC()) { | ||
| return DateTimeUtil.microsFromTimestamptz((OffsetDateTime) value); | ||
| } else { | ||
| return DateTimeUtil.microsFromTimestamp((LocalDateTime) value); | ||
| } | ||
| case FIXED: | ||
| return ByteBuffer.wrap((byte[]) value); | ||
| default: | ||
| return value; | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testPartitionValueTypes() { | ||
| RowWrapper rowWrapper = new RowWrapper(SCHEMA.asStruct()); | ||
| Iterable<Row> rows = RandomData.generate(SCHEMA, 10, 1993); | ||
|
|
||
| for (int i = 0; i < SUPPORTED_PRIMITIVES.length; i++) { | ||
| String column = SUPPORTED_PRIMITIVES[i]; | ||
|
|
||
| PartitionSpec spec = PartitionSpec.builderFor(SCHEMA).identity(column).build(); | ||
| Type type = spec.schema().findType(column); | ||
| Class<?>[] javaClasses = spec.javaClasses(); | ||
|
|
||
| PartitionKey pk = new PartitionKey(spec, SCHEMA); | ||
|
|
||
| for (Row row : rows) { | ||
| pk.partition(rowWrapper.wrap(row)); | ||
| Object expected = row.getField(i); | ||
| Assert.assertEquals("Partition with column " + column + " should have one field.", 1, pk.size()); | ||
| Assert.assertEquals("Partition with column " + column + " should have the expected values", | ||
| transform(expected, type), pk.get(0, javaClasses[0])); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testNestedPartitionValues() { | ||
| Schema nestedSchema = new Schema(Types.NestedField.optional(1001, "nested", SCHEMA.asStruct())); | ||
| RowWrapper rowWrapper = new RowWrapper(nestedSchema.asStruct()); | ||
| Iterable<Row> rows = RandomData.generate(nestedSchema, 10, 1994); | ||
|
|
||
| for (int i = 0; i < SUPPORTED_PRIMITIVES.length; i++) { | ||
| String column = String.format("nested.%s", SUPPORTED_PRIMITIVES[i]); | ||
|
|
||
| PartitionSpec spec = PartitionSpec.builderFor(nestedSchema).identity(column).build(); | ||
| Type type = spec.schema().findType(column); | ||
| Class<?>[] javaClasses = spec.javaClasses(); | ||
|
|
||
| PartitionKey pk = new PartitionKey(spec, nestedSchema); | ||
|
|
||
| for (Row row : rows) { | ||
| pk.partition(rowWrapper.wrap(row)); | ||
|
|
||
| Object expected = ((Row) row.getField(0)).getField(i); | ||
| Assert.assertEquals("Partition with nested column " + column + " should have one field.", | ||
| 1, pk.size()); | ||
| Assert.assertEquals("Partition with nested column " + column + "should have the expected values.", | ||
| transform(expected, type), pk.get(0, javaClasses[0])); | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test based on Spark's
TestPartitionValues? That tests every supported type, null values, and different column orders.