Add TypeToFlinkType: convert iceberg types to Flink types #1174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openinx
reviewed
Jul 9, 2020
| // The conversion is not a 1:1 mapping, so we just check iceberg types. | ||
| Assert.assertEquals( | ||
| icebergSchema.asStruct(), | ||
| FlinkSchemaUtil.convert(FlinkSchemaUtil.toSchema(FlinkSchemaUtil.convert(icebergSchema))).asStruct()); |
Member
There was a problem hiding this comment.
I'd prefer to provide some separate unit tests to address the conversion differences ( so that we won't regress).
Contributor
Author
There was a problem hiding this comment.
I'll add tests for the conversion differences.
Contributor
|
@JingsongLi, I added some comments about the changes here to #1182. |
JingsongLi
force-pushed
the
typeToFlinkType
branch
from
884e7b4 to
ab99a29
Compare
Contributor
Author
|
Synchronized with #1182. |
rdblue
reviewed
Jul 14, 2020
flink/src/main/java/org/apache/iceberg/flink/FlinkSchemaUtil.java
Outdated
Show resolved
Hide resolved
Contributor
JingsongLi
force-pushed
the
typeToFlinkType
branch
from
ab99a29 to
814672b
Compare
Contributor
|
Thanks for rebasing! CI has been fixed in master so I reopened this to run tests. They are passing, so I'll merge. |
HotSushi
pushed a commit
to HotSushi/iceberg
that referenced
this pull request
Jul 23, 2020
cmathiesen
pushed a commit
to ExpediaGroup/iceberg
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converter between Flink types and Iceberg type.
The conversion is not a 1:1 mapping that not allows back-and-forth conversion. So some information might get lost during the back-and-forth conversion.
(background: FlinkCatalog need convert iceberg tables to Flink tables)