REST: Refactor docker image files #11676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Nov 29, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Two touch-ups:
- The user and repository can differ if you're using a non-personal dockerhub.
- Let's add an environment variable under
env:so folks can easily swap outapachewith their own user.
ajantha-bhat
force-pushed
the
cleanup
branch
from
2a3d327 to
0a0deb1
Compare
Fokko
approved these changes
Nov 29, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Thanks @ajantha-bhat LGTM!
sungwy
approved these changes
Nov 29, 2024
Contributor
sungwy
left a comment
sungwy
left a comment
There was a problem hiding this comment.
LGTM as well @ajantha-bhat - thank you for jumping on this fix!
sungwy
reviewed
Nov 29, 2024
kevinjqliu
reviewed
Nov 29, 2024
kevinjqliu
approved these changes
Nov 29, 2024
kevinjqliu
reviewed
Nov 29, 2024
Comment on lines
29
to
+31
| DOCKER_IMAGE_TAG: iceberg-rest-fixture | ||
| DOCKER_IMAGE_VERSION: latest | ||
| DOCKER_REPOSITORY: apache |
Contributor
There was a problem hiding this comment.
Suggested change
| DOCKER_IMAGE_TAG: iceberg-rest-fixture | |
| DOCKER_IMAGE_VERSION: latest | |
| DOCKER_REPOSITORY: apache | |
| DOCKER_REPOSITORY: apache | |
| DOCKER_IMAGE_TAG: iceberg-rest-fixture | |
| DOCKER_IMAGE_VERSION: latest |
nit
Member
Author
There was a problem hiding this comment.
keys were alphabetically sorted before. I didn't get the intention behind this comment.
Contributor
There was a problem hiding this comment.
this was to match the order of the docker name
part of:
docker push $DOCKER_REPOSITORY/$DOCKER_IMAGE_TAG:$DOCKER_IMAGE_VERSION
again, nit comment :)
Contributor
|
Let's move this forward. Once the Infra ticket is resolved, we can push this forward :) Thanks again @ajantha-bhat for fixing this, and thanks @kevinjqliu and @sungwy for the review 🙌 |
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
* REST: Refactor docker image files * update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.