ORC: Simplify logic to determine which columns have stats #1167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Merged. Thanks for reviewing, @rdsr! |
edgarRd
reviewed
Jul 6, 2020
| public Set<Integer> record(TypeDescription record, List<String> names, List<Set<Integer>> fields) { | ||
| ImmutableSet.Builder<Integer> result = ImmutableSet.builder(); | ||
| fields.stream().filter(Objects::nonNull).forEach(result::addAll); | ||
| record.getChildren().stream().map(ORCSchemaUtil::fieldId).forEach(result::add); |
Contributor
There was a problem hiding this comment.
Just to verify, this would fail if there's any column that does not have an Iceberg ID. Is that preferred to skipping the metrics instead?
Contributor
Author
There was a problem hiding this comment.
I think so. This is called when Iceberg wrote the file, so we should be able to assume the IDs are present, right?
Contributor
There was a problem hiding this comment.
If the ORC files are written by Iceberg it should be fine. I was thinking for the case of importing existing ORC files although we'd need to implement name mapping fallback strategy.
Contributor
There was a problem hiding this comment.
I think this breaks pretty much any import of non-Iceberg ORC tables via SparkTableUtil.
cmathiesen
pushed a commit
to ExpediaGroup/iceberg
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the visitor used to determine which ORC columns should have stats stored in table metadata. It uses the new visitor introduced in #1140. This is an alternative implementation to #1112.