Ignore partition fields that are dropped from the current-schema #11604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
force-pushed
the
fd-ignore-deleted-schema-evolution-fields
branch
from
7557e3a to
d96f947
Compare
Fokko
force-pushed
the
fd-ignore-deleted-schema-evolution-fields
branch
from
d96f947 to
33e5712
Compare
This was referenced Dec 3, 2024
Contributor
Author
|
This is actually unsafe for V1 tables :3 |
This was referenced Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4563
I'm open to other angles to fix the problem, but quite a few folks seem to run into this. This PR skips over the field, so it will be excluded from the evaluation. The field-id projection makes sure that we skip over the field.
Another option would be to extract the field from the struct, but that's far down in the execution path. Besides that, there is zero value in it, because the field has been dropped from the current schema, so you will never filter on it.