Skip to content

Conversation

@manuzhang
Copy link
Member

No description provided.

@github-actions github-actions bot added the docs label Oct 29, 2024
@manuzhang manuzhang changed the title Docs: warn doesn't work for migration procedures Docs: warn parallelism > 1 doesn't work for migration procedures Oct 29, 2024
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks reasonable to me to warn the users waiting the actual fix.

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fair to fix this down the line. One small nit on the wording, I try to avoid we.

manuzhang and others added 3 commits October 29, 2024 19:03
Co-authored-by: Fokko Driesprong <[email protected]>
Co-authored-by: Fokko Driesprong <[email protected]>
Co-authored-by: Fokko Driesprong <[email protected]>
@RussellSpitzer RussellSpitzer merged commit ea61ee4 into apache:main Oct 31, 2024
@RussellSpitzer
Copy link
Member

RussellSpitzer commented Oct 31, 2024

Thanks @manuzhang We'll figure out that fix before the next release I promise. Thanks @Fokko and @jbonofre for review

RussellSpitzer pushed a commit to RussellSpitzer/iceberg that referenced this pull request Nov 4, 2024
@manuzhang manuzhang deleted the add-warning-parallelism branch November 18, 2024 08:46
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants