Skip to content

Remove iceberg-pig #11380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nastra merged 1 commit into from
Nov 13, 2024
Merged

Remove iceberg-pig #11380

nastra merged 1 commit into from
Nov 13, 2024

Conversation

@jbonofre
Copy link
Member

@jbonofre jbonofre commented Oct 23, 2024

Following #11379 this PR completely removes iceberg-pig (for Iceberg 1.8.0).

@manuzhang
Copy link
Member

manuzhang commented Oct 23, 2024

When I try removing Hive 2 in #10996, I find both Hive and Pig are referenced in https://github.com/apache/iceberg/blob/main/mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java#L350. Shall we remove them as well?

@jbonofre
Copy link
Member Author

jbonofre commented Oct 24, 2024

@manuzhang good catch ! I think it makes sense to remove from there. I will update the PR, thanks !

@github-actions github-actions bot added the MR label Oct 24, 2024
@jbonofre
Copy link
Member Author

jbonofre commented Oct 24, 2024

@manuzhang I did a more "agressive" pass on removing pig 😄

@ajantha-bhat
Copy link
Member

ajantha-bhat commented Oct 24, 2024

we can keep it in Draft since it is for 1.8.0

@jbonofre jbonofre marked this pull request as draft October 24, 2024 12:58
@jbonofre
Copy link
Member Author

jbonofre commented Oct 24, 2024

@ajantha-bhat done

@nastra
Copy link
Contributor

nastra commented Oct 24, 2024

please also update all of the yaml files for GH actions

@Fokko Fokko added this to the Iceberg 1.8.0 milestone Nov 5, 2024
@Fokko
Copy link
Contributor

Fokko commented Nov 13, 2024

@jbonofre I think we're ready :)

@jbonofre
Copy link
Member Author

jbonofre commented Nov 13, 2024

@Fokko yup changing the PR status :)

@github-actions github-actions bot added the INFRA label Nov 13, 2024
@jbonofre jbonofre requested review from Fokko and nastra November 13, 2024 12:38
@jbonofre
Copy link
Member Author

jbonofre commented Nov 13, 2024

@nastra I did a pass to clean gradle/github resources.

@jbonofre jbonofre marked this pull request as ready for review November 13, 2024 12:38
@jbonofre
Copy link
Member Author

jbonofre commented Nov 13, 2024

@Fokko the PR is ready to review (I added additional cleanups).

Fokko
Fokko reviewed Nov 13, 2024
View reviewed changes
gradle/libs.versions.toml Outdated
Comment on lines 79 to 78
pig = "0.17.0"
parquet = "1.14.3"
Copy link
Contributor

@Fokko Fokko Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a merge conflict gone wrong. We've fallen back to 1.13.1 due to a bug in the dictionary encoding, we have #11502 to bump to 1.14.4

Copy link
Member Author

@jbonofre jbonofre Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@nastra nastra merged commit 0280885 into apache:main Nov 13, 2024
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
@jbonofre @zachdisc
Pig: Remove iceberg-pig (apache#11380)
28eb1b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fokko Fokko Fokko left review comments

@nastra nastra nastra approved these changes

@manuzhang manuzhang manuzhang approved these changes

Assignees

No one assigned

Labels

build docs INFRA MR pig

Projects

None yet

Milestone

Iceberg 1.8.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jbonofre @manuzhang @ajantha-bhat @nastra @Fokko