Skip to content

Conversation

@hsiang-c
Copy link
Contributor

Note to reviewers

  • Closes List all AWS S3 properties in the docs #10674
  • I moved S3 properties to its own doc (aws-s3-fileio-properties.md) and link to it from the original aws.md
  • In the aws-s3-fileio-properties.md
    • I tried to summarize all S3 properties at the top table
    • Each row in the table points to a section below with more details.
    • In a section, added a Language column for properties that are supported by multiple languages.

@github-actions github-actions bot added the docs label Oct 15, 2024
@hsiang-c
Copy link
Contributor Author

cc @Fokko @Xuanwo for reviews, thanks.


| S3 Property | Go | Java | Python | Rust |
|-------------------------------------------------------------------------------------------|---|---|---|---|
| [Progressive Multipart Upload](aws-s3-fileio-properties#progressive-multipart-upload) | | v | | |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pyiceberg fileIO implemenation replies on Pyarrow and fsspec (depends on user configuration to choose which one to use in the background in the end). AFAIK, both lib (Pyarrow.fs.S3FileSystem and s3fs.core.S3FileSystem supports multipart upload.)

I haven't checked the other properties in this list, so there might be other things already supported by Python but didn't marked correctly.

Copy link
Contributor Author

@hsiang-c hsiang-c Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TiansuYu Thank you for your review and feedback.

You're right about the capability of Python libraries (Pyarrow and fsspec).

At the moment, I only list s3 properties used in the Iceberg implementations (and therefore configurable in Iceberg). I didn't cover all possible s3 properties from the libraries used by Java/Python/Go/Rust.

Take Rust as another example, we can set the storage class in Rust's OpenDAL library, however, Iceberg's Rust config parsing function doesn't recognize it yet. Therefore, I didn't mark it as supported.

@github-actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 22, 2024
@github-actions
Copy link

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List all AWS S3 properties in the docs

2 participants