docs: fix spec sidebar #11316
Closed
docs: fix spec sidebar #11316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Specification
Contributor
|
@jdockerty while this appears to "fix" the sidebar issue, I don't think it results in the right header levels. |
Author
|
Closing in favour of #11067 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, the specification page sidebar does not show properly. It cuts off from the "File System Operations" section; whilst the anchor links do work, navigating this page is a little awkward when you need to jump way further down.
Now that this side bar is fixed, it should be much nicer. For reference, the same level of heading is used within the
view-spec.mdpage, in which the side bar populates correctly.Example
before this change
Notice here how there are no other headings past the "File System Operations", there should be many more linking to the specification and data types etc.
after this change