-
Notifications
You must be signed in to change notification settings - Fork 3k
Spec: Add cross-region bucket access property to config #11260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec: Add cross-region bucket access property to config #11260
Conversation
|
@nastra Please review, If this looks good, post PR #10722 and #10576, will move this change to fileIo properties (#10722 (comment)) |
|
@nastra Could you please take a look.. would this be correct place to add this info? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you please resolve the conflicts? Looks like the impl changes were merged as part of #11259
407e413 to
969f9d2
Compare
|
@nastra Resolved conflicts, please review |
|
@nastra Could you please review again? |
|
the changes LGTM and given this is only a doc change (by stating a new property that's being supported) I don't think this PR would have to go through the normal voting process on the mailing list. Hence it would be good to get an additional approval. |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
|
Reached over in iceberg-slack to get the additional review |
RussellSpitzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Approved and Merged, thanks @munendrasn for the PR and @Fokko and @nastra for reviewing |
Cross region bucket access supported is included in #9804
cc @singhpk234