Skip to content

Conversation

@munendrasn
Copy link
Contributor

Cross region bucket access supported is included in #9804
cc @singhpk234

@munendrasn
Copy link
Contributor Author

@nastra Please review, If this looks good, post PR #10722 and #10576, will move this change to fileIo properties (#10722 (comment))

@munendrasn
Copy link
Contributor Author

@nastra Could you please take a look.. would this be correct place to add this info?

Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please resolve the conflicts? Looks like the impl changes were merged as part of #11259

@munendrasn munendrasn force-pushed the rest-catalog-cross-region branch from 407e413 to 969f9d2 Compare November 15, 2024 07:23
@munendrasn
Copy link
Contributor Author

@nastra Resolved conflicts, please review

@munendrasn
Copy link
Contributor Author

@nastra Could you please review again?

@munendrasn
Copy link
Contributor Author

@nastra @Fokko are the changes good to be merged?

@nastra
Copy link
Contributor

nastra commented Dec 12, 2024

the changes LGTM and given this is only a doc change (by stating a new property that's being supported) I don't think this PR would have to go through the normal voting process on the mailing list. Hence it would be good to get an additional approval.
/cc @RussellSpitzer

@github-actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 12, 2025
@munendrasn
Copy link
Contributor Author

munendrasn commented Jan 13, 2025

Reached over in iceberg-slack to get the additional review

Copy link
Member

@RussellSpitzer RussellSpitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RussellSpitzer RussellSpitzer merged commit 3247964 into apache:main Jan 13, 2025
@RussellSpitzer
Copy link
Member

Approved and Merged, thanks @munendrasn for the PR and @Fokko and @nastra for reviewing

@munendrasn munendrasn deleted the rest-catalog-cross-region branch January 13, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants