-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Add support for view-default
property in catalog
#11064
Open
ebyhr
wants to merge
3
commits into
apache:main
Choose a base branch
from
ebyhr:ebi/view-default-properties
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/view-default-properties
branch
from
September 2, 2024 03:05
a0ed40f
to
a130aaa
Compare
ebyhr
force-pushed
the
ebi/view-default-properties
branch
from
September 2, 2024 04:03
a130aaa
to
2d41458
Compare
ebyhr
force-pushed
the
ebi/view-default-properties
branch
4 times, most recently
from
September 2, 2024 05:21
76591c2
to
c4aa6ae
Compare
ebyhr
force-pushed
the
ebi/view-default-properties
branch
from
September 2, 2024 05:41
c4aa6ae
to
1b935cb
Compare
CI hit #10172 |
@RussellSpitzer Can you review this PR when you have time? |
singhpk234
reviewed
Sep 3, 2024
ebyhr
force-pushed
the
ebi/view-default-properties
branch
from
September 3, 2024 23:51
1b935cb
to
8206c5f
Compare
nastra
reviewed
Sep 9, 2024
nastra
reviewed
Sep 9, 2024
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java
Outdated
Show resolved
Hide resolved
nk1506
reviewed
Sep 12, 2024
@@ -29,6 +29,7 @@ private CatalogProperties() {} | |||
public static final String WAREHOUSE_LOCATION = "warehouse"; | |||
public static final String TABLE_DEFAULT_PREFIX = "table-default."; | |||
public static final String TABLE_OVERRIDE_PREFIX = "table-override."; | |||
public static final String VIEW_DEFAULT_PREFIX = "view-default."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10822