Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add support for view-default property in catalog #11064

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ebyhr
Copy link
Contributor

@ebyhr ebyhr commented Sep 2, 2024

Fixes #10822

@ebyhr ebyhr force-pushed the ebi/view-default-properties branch from a0ed40f to a130aaa Compare September 2, 2024 03:05
@ebyhr ebyhr marked this pull request as draft September 2, 2024 03:17
@ebyhr ebyhr force-pushed the ebi/view-default-properties branch from a130aaa to 2d41458 Compare September 2, 2024 04:03
@ebyhr ebyhr force-pushed the ebi/view-default-properties branch 4 times, most recently from 76591c2 to c4aa6ae Compare September 2, 2024 05:21
@ebyhr ebyhr force-pushed the ebi/view-default-properties branch from c4aa6ae to 1b935cb Compare September 2, 2024 05:41
@ebyhr
Copy link
Contributor Author

ebyhr commented Sep 2, 2024

CI hit #10172

@ebyhr
Copy link
Contributor Author

ebyhr commented Sep 2, 2024

@RussellSpitzer Can you review this PR when you have time?

@ebyhr ebyhr force-pushed the ebi/view-default-properties branch from 1b935cb to 8206c5f Compare September 3, 2024 23:51
@ebyhr ebyhr marked this pull request as ready for review September 4, 2024 00:00
@@ -29,6 +29,7 @@ private CatalogProperties() {}
public static final String WAREHOUSE_LOCATION = "warehouse";
public static final String TABLE_DEFAULT_PREFIX = "table-default.";
public static final String TABLE_OVERRIDE_PREFIX = "table-override.";
public static final String VIEW_DEFAULT_PREFIX = "view-default.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ebyhr for working on this. I also raised a similar PR which I think is not required anymore. Do you think we should also add "view-override." ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View Default Properties in the Catalog
4 participants