Reuse the common methods in serveral RandomData classes. #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hi @rdblue , Mind to take a look ? the next flink patch will depends on this patch (so that we could reuse parts of the random utility methods), thanks. https://github.com/openinx/incubator-iceberg/commit/72cf683656dd993334742f0edc514e0289f543f8 |
rdblue
reviewed
Jun 9, 2020
| public class RandomUtil { | ||
|
|
||
| private RandomUtil() { | ||
|
|
Contributor
There was a problem hiding this comment.
Nit: no need for a blank line here.
rdblue
reviewed
Jun 9, 2020
| import org.apache.iceberg.types.Type; | ||
| import org.apache.iceberg.types.Types; | ||
|
|
||
| public class RandomUtil { |
Contributor
There was a problem hiding this comment.
I don't think this class should be in src/main. Can you move it to src/test?
Contributor
|
Looks good other than the class in the wrong source tree. |
Contributor
|
Merged. Thanks, @openinx! |
cmathiesen
pushed a commit
to ExpediaGroup/iceberg
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to pull request the flink parquet reader & writer (#1096), I scanned the unit test and found that the RandomData was copied and pasted in several unit test files. So I made this pull request to put it into the utility class and let the unit test files share it.