Skip to content

Conversation

@stevenzwu
Copy link
Contributor

This is a clean back port except for TestIcebergSpeculativeExecutionSupport due minor differences of Flink APIs among 1.18, 1.19, 1.20.

@stevenzwu stevenzwu requested a review from pvary August 26, 2024 16:06
@github-actions github-actions bot added the flink label Aug 26, 2024
@pvary
Copy link
Contributor

pvary commented Aug 26, 2024

This is a clean back port except for TestIcebergSpeculativeExecutionSupport due minor differences of Flink APIs among 1.18, 1.19, 1.20.

Could you please highlight these differences?
It would be easier to review them.

// execution
if (getRuntimeContext().getAttemptNumber() <= 0) {
// Simulate slow subtask 0 with attempt 0
if (getRuntimeContext().getIndexOfThisSubtask() == 0
Copy link
Contributor Author

@stevenzwu stevenzwu Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is different with 1.19 and 1.20 which exposes these via task info getRuntimeContext().getTaskInfo()

Copy link
Contributor

@pvary pvary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the highlights @stevenzwu !

@stevenzwu stevenzwu merged commit bf00d51 into apache:main Aug 27, 2024
@stevenzwu stevenzwu deleted the backport-10832-infer-parallelism branch August 27, 2024 15:33
jenbaldwin pushed a commit to Teradata/iceberg that referenced this pull request Sep 17, 2024
* main: (208 commits)
  Docs: Fix Flink 1.20 support versions (apache#11065)
  Flink: Fix compile warning (apache#11072)
  Docs: Initial committer guidelines and requirements for merging (apache#10780)
  Core: Refactor ZOrderByteUtils (apache#10624)
  API: implement types timestamp_ns and timestamptz_ns (apache#9008)
  Build: Bump com.google.errorprone:error_prone_annotations (apache#11055)
  Build: Bump mkdocs-material from 9.5.33 to 9.5.34 (apache#11062)
  Flink: Backport PR apache#10526 to v1.18 and v1.20 (apache#11018)
  Kafka Connect: Disable publish tasks in runtime project (apache#11032)
  Flink: add unit tests for range distribution on bucket partition column (apache#11033)
  Spark 3.5: Use FileGenerationUtil in PlanningBenchmark (apache#11027)
  Core: Add benchmark for appending files (apache#11029)
  Build: Ignore benchmark output folders across all modules (apache#11030)
  Spec: Add RemovePartitionSpecsUpdate REST update type (apache#10846)
  Docs: bump latest version to 1.6.1 (apache#11036)
  OpenAPI, Build: Apply spotless to testFixtures source code (apache#11024)
  Core: Generate realistic bounds in benchmarks (apache#11022)
  Add REST Compatibility Kit (apache#10908)
  Flink: backport PR apache#10832 of inferring parallelism in FLIP-27 source (apache#11009)
  Docs: Add Druid docs url to sidebar (apache#10997)
  ...
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
czy006 pushed a commit to czy006/iceberg that referenced this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants