Exclude Guava from the compile classpath #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FYI @rdsr, @shardulm94, @massdosage. This also fixes the classes added in #1064 that were not updated by #1076. |
Contributor
|
+1 LGTM |
rdsr
approved these changes
May 29, 2020
| testCompile.extendsFrom compileOnly | ||
|
|
||
| compileClasspath { | ||
| // do not exclude Guava so the bundle project can reference classes. |
Contributor
There was a problem hiding this comment.
nit: slight rewording? . Exclude guava from iceberg modules except ... ?
Contributor
Author
|
Merging to fix master. I'll clarify the comment in a follow-up. |
massdosage
reviewed
Jun 1, 2020
| configurations { | ||
| testCompile.extendsFrom compileOnly | ||
|
|
||
| compileClasspath { |
Contributor
There was a problem hiding this comment.
This is better than enforcing the exclusion via Checkstyle as this will now be evident at compile time rather than when building the project. Nice.
cmathiesen
pushed a commit
to ExpediaGroup/iceberg
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This excludes Guava from
compileClasspathso that Iceberg cannot use the classes directly, but tests will still pass because thetestRuntimeclasspath does have transitive Guava classes.