-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Infra, Docs: Publish Apache Iceberg 1.6.0 release #10752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Fokko do you mind to take a look on this one ? |
Fokko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍
|
@nastra, @jbonofre: Since release notes gonna take sometime, I have opened #10754 because I think open PR is failing (#10753 (comment)) because we have a new tag and old version is not matching? |
Fokko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @jbonofre for working on this 👍
@ajantha-bhat Wanted to check if you have any more comments before merging this
nastra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RevAPI update is still missing, see also my earlier comment: #10752 (comment)
|
@nastra revapi has been updated already by another PR, so not included in this one. |
ah sorry I missed that update |
nastra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Dependency update info is good to have along with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jbonofre! Thanks @ajantha-bhat @Fokko @nastra @hussein-awala for reviewing.
From my side looks good, seems like we wanted to get in dependency updates in the release notes based on https://github.com/apache/iceberg/pull/10752/files#r1689845177? So I'll hold off on merging
Co-authored-by: Eduard Tudenhoefner <[email protected]>
|
@amogh-jahagirdar as requested by @nastra I added a |
|
Thanks @jbonofre ! |
|
@amogh-jahagirdar thanks ! I will do the announcement. |
Co-authored-by: Eduard Tudenhoefner <[email protected]>
No description provided.