Skip to content

Conversation

@jbonofre
Copy link
Member

No description provided.

@jbonofre
Copy link
Member Author

@Fokko do you mind to take a look on this one ?

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@nastra
Copy link
Contributor

nastra commented Jul 23, 2024

@jbonofre can you please also update RevAPI to compare against the new version? This should be done here:

oldVersion = "1.5.0"

@ajantha-bhat
Copy link
Member

@nastra, @jbonofre: Since release notes gonna take sometime, I have opened #10754 because I think open PR is failing (#10753 (comment)) because we have a new tag and old version is not matching?

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jbonofre for working on this 👍

@ajantha-bhat Wanted to check if you have any more comments before merging this

Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RevAPI update is still missing, see also my earlier comment: #10752 (comment)

@jbonofre
Copy link
Member Author

@nastra revapi has been updated already by another PR, so not included in this one.

@nastra
Copy link
Contributor

nastra commented Jul 24, 2024

@nastra revapi has been updated already by another PR, so not included in this one.

ah sorry I missed that update

Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few minor comments

Copy link
Member

@ajantha-bhat ajantha-bhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Dependency update info is good to have along with this.

@amogh-jahagirdar amogh-jahagirdar changed the title Publish Apache Iceberg 1.6.0 release Infra, Docs: Publish Apache Iceberg 1.6.0 release Jul 25, 2024
Copy link
Contributor

@amogh-jahagirdar amogh-jahagirdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbonofre! Thanks @ajantha-bhat @Fokko @nastra @hussein-awala for reviewing.

From my side looks good, seems like we wanted to get in dependency updates in the release notes based on https://github.com/apache/iceberg/pull/10752/files#r1689845177? So I'll hold off on merging

Co-authored-by: Eduard Tudenhoefner <[email protected]>
@jbonofre
Copy link
Member Author

@amogh-jahagirdar as requested by @nastra I added a Dependencies section

@amogh-jahagirdar
Copy link
Contributor

Thanks @jbonofre !

@amogh-jahagirdar amogh-jahagirdar merged commit a309728 into apache:main Jul 25, 2024
@jbonofre
Copy link
Member Author

@amogh-jahagirdar thanks ! I will do the announcement.

zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants