-
Notifications
You must be signed in to change notification settings - Fork 3k
Add shaded Guava module #1068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add shaded Guava module #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # api/src/main/java/org/apache/iceberg/events/Listeners.java
"com.google.common.shaded"
* Swap to shaded guava in common and core modules * Shade in arrow module
…diaGroup/incubator-iceberg.git into relocated-external-dependencies
# Conflicts: # api/src/main/java/org/apache/iceberg/Filterable.java # api/src/main/java/org/apache/iceberg/types/TypeUtil.java # core/src/main/java/org/apache/iceberg/FilteredManifest.java # core/src/main/java/org/apache/iceberg/ManifestReader.java # core/src/main/java/org/apache/iceberg/SchemaUpdate.java # core/src/main/java/org/apache/iceberg/avro/AvroIterable.java # core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java # core/src/main/java/org/apache/iceberg/util/ParallelIterable.java # data/src/main/java/org/apache/iceberg/data/parquet/GenericParquetWriter.java # mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java # parquet/src/main/java/org/apache/iceberg/parquet/MessageTypeToType.java # spark/src/main/java/org/apache/iceberg/spark/data/SparkAvroWriter.java # spark/src/main/java/org/apache/iceberg/spark/data/SparkParquetWriters.java # spark/src/main/java/org/apache/iceberg/spark/source/BaseDataReader.java # spark/src/main/java/org/apache/iceberg/spark/source/RowDataReader.java # spark/src/test/java/org/apache/iceberg/TestDataFileSerialization.java
Contributor
Author
|
I tested this locally, so I didn't wait for CI to complete. |
waterlx
added a commit
to waterlx/incubator-iceberg
that referenced
this pull request
May 28, 2020
waterlx
added a commit
to waterlx/incubator-iceberg
that referenced
this pull request
May 28, 2020
Member
|
cc @dbtsai |
waterlx
added a commit
to waterlx/incubator-iceberg
that referenced
this pull request
Jun 3, 2020
simonsssu
pushed a commit
to simonsssu/iceberg
that referenced
this pull request
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #935. The purpose of this PR is to merge master into that branch and merge, because there are so many commit conflicts with the import changes.
Co-authored-by: awoodhead [email protected]
Co-authored-by: cmathiesen [email protected]