Skip to content

Conversation

@manuzhang
Copy link
Member

No description provided.

@ajantha-bhat
Copy link
Member

Can you please add a detailed PR description about the design choice.
Is it for improving the equality delete read performance to load the equality delete files from parquet to rocks db to avoid opening same files again again? Why did we chose rocks db instead of cache? Due to memory limitation?

You can carry out a POC and better to have a mailing list discussion on the same as an improvement proposal.

@manuzhang
Copy link
Member Author

@ajantha-bhat Thanks for great comments. As I said in #10054, I've already carried out PoC but yet found time to integrate with existing API, cache mechanism, etc. I will add more descriptions and open a discussion on the dev list once the code is ready for review.

@github-actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 10, 2024
@github-actions
Copy link

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Nov 17, 2024
@manuzhang manuzhang deleted the rocksdb-eq-deletes branch May 7, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants