Fix partition spec and transforms in python #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rdblue merged 1 commit into apache:master from jun-he:jun/py-fix-partition-spec

May 18, 2020

Collaborator

jun-he commented May 17, 2020

This PR fixed a few bugs/issues in partition spec and transforms classes

In partition spec source_column.types should be source_column.type
type_id is missed or is mistakenly used as type_id() in multiple classes
In dates class, __str__ will cause RecursionError as it calls itself.
Fixed returning TruncateLong instead of TruncateInteger for TypeID.LONG.
Fixed truncate static method to use the right input parameter type_var.
added unit tests in python, similar to Java partition spec base test.


          Fix partition spec and transforms in python

98a32aa

rdblue merged commit 49de952 into apache:master

Contributor

rdblue commented May 18, 2020

Thanks, @jun-he! Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet