TIME_MILLIS support to GenericParquetReader (issue #502) #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you add a test for this? |
Contributor
Author
done; pls check out |
rdblue
reviewed
May 18, 2020
| required(116, "dec_38_10", Types.DecimalType.of(38, 10)), // maximum precision | ||
| required(117, "time", Types.TimeType.get()) | ||
| required(117, "time", Types.TimeType.get()), | ||
| required(118, "time_ms", Types.TimeType.get()) |
Contributor
There was a problem hiding this comment.
Iceberg won't actually write data in milliseconds, so we would need to write a Parquet file using the annotation and confirm that a time column is correct when reading.
Can you remove this change?
Contributor
Author
There was a problem hiding this comment.
@rdblue do we have any boilerplate code I can use to do that?
…in milliseconds, so we would need to write a Parquet file using the annotation and confirm that a time column is correct when reading.', so this test won't work.
Contributor
|
We don't have anything currently, but you can use |
Contributor
|
@pranaydharmale, I went ahead and merged this since it looks correct. We can follow up with that test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for TIME_MILLIS to GenericParquetReader.