Merged
Conversation
Contributor
Author
|
Hm this should have the same line number delta as #9929 since I just copied the folder and edited 2 lines in that copy, not sure why this is adding 8700 lines instead of 8538. Let me check, maybe some changes got added to the 1.5.0 docs in a later commit. |
Contributor
Author
Collaborator
|
Yeah, so three main things I checked:
LGTM! |
Fokko
approved these changes
Apr 24, 2024
Contributor
Fokko
left a comment
There was a problem hiding this comment.
Thanks @amogh-jahagirdar and @bitsondatadev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 1.5.1 docs similar to https://github.com/apache/iceberg/pull/9929/files