AWS: Make sure Signer + User Agent config are both applied #10198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
remote-signing-with-user-agent-config
branch
from
f04c343 to
0ab810f
Compare
nastra
force-pushed
the
remote-signing-with-user-agent-config
branch
from
0ab810f to
11971ff
Compare
Fokko
approved these changes
Apr 22, 2024
amogh-jahagirdar
approved these changes
Apr 22, 2024
Contributor
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
Great find @nastra !
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
parthchandra
pushed a commit
to parthchandra/iceberg
that referenced
this pull request
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the remote signing configuration is being overriden/ignored when the user-agent configuration is being applied. This is because calling
overrideConfiguration(Consumer<ClientOverrideConfiguration.Builder> overrideConfiguration)creates a newClientOverrideConfigurationand ignores any existing ones that might have been set previously.The
s3RemoteSigningEnabledWithUserAgent()test reproduces the issue and fails without the fix being proposed here.