-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Parquet: Use native getRowIndexOffset support instead of calculating it #10107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d82b2c7 to
a1bcf21
Compare
.palantir/revapi.yml
Outdated
| \ org.apache.iceberg.Schema, org.apache.iceberg.TableScanContext)" | ||
| justification: "Removing deprecated code" | ||
| "1.5.0": | ||
| org.apache.iceberg:iceberg-parquet: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can break existing APIs without deprecating them first. Please check https://iceberg.apache.org/contribute/#adding-new-functionality-without-breaking-apis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nastra thanks for the pointer. I have retained the old versions of the methods but deprecated them.
a1bcf21 to
a640047
Compare
|
@flyrain I have updated your PR. Please review. cc @chenjunjiedada @Fokko. |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
|
@wypoon Would you like to reopen this PR? |
|
@huaxingao yes, I'll be happy to reopen it. The versions in the deprecation comments need to be updated. I'll update the PR soon. |
|
I don't see how to reopen this. I have opened a new PR, #11520. |
This is an update of #6056.
In the original PR, some APIs were changed which are now checked by revapi. Instead of changing the APIs, I have retained but deprecated the original versions of the methods and added new versions with default implementations.
I have also ported the change in
ColumnarBatchReaderto Spark 3.4 and 3.5.