Skip to content

Use wrapper to add entries from added manifest #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chenjunjiedada wants to merge 1 commit into from
Closed

Use wrapper to add entries from added manifest #1008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ private ManifestFile createManifest(int specId, List<ManifestFile> bin) throws I
return mergeManifests.get(bin);
}

ManifestWriter writer = newManifestWriter(ops.current().spec());
ManifestWriter writer = newManifestWriter(ops.current().specsById().get(specId));
try {
for (ManifestFile manifest : bin) {
try (ManifestReader reader = ManifestFiles.read(manifest, ops.io(), ops.current().specsById())) {
Expand All @@ -676,11 +676,11 @@ private ManifestFile createManifest(int specId, List<ManifestFile> bin) throws I
// suppress deletes from previous snapshots. only files deleted by this snapshot
// should be added to the new manifest
if (entry.snapshotId() == snapshotId()) {
writer.addEntry(entry);
writer.delete(entry);
}
} else if (entry.status() == Status.ADDED && entry.snapshotId() == snapshotId()) {
// adds from this snapshot are still adds, otherwise they should be existing
writer.addEntry(entry);
writer.add(entry);
} else {
// add all files from the old manifest as existing files
writer.existing(entry);
Expand Down