feat: sql catalog support update table #862
Open
+315
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liurenjie1024
requested changes
Jan 3, 2025
There was a problem hiding this comment.
Thanks @Li0k for this pr, but I have concerning introducing update table at this moment as there are many missing features such as conflict detection, commit retry.
|
|
||
| /// Returns snapshot references. | ||
| #[inline] | ||
| pub fn snapshot_refs(&self) -> &HashMap<String, SnapshotReference> { |
There was a problem hiding this comment.
Why we add this method? We already have lookup method for snapshot
| @@ -255,7 +255,7 @@ pub struct TableCreation { | |||
|
|
|||
| /// TableCommit represents the commit of a table in the catalog. | |||
| #[derive(Debug, TypedBuilder)] | |||
| #[builder(build_method(vis = "pub(crate)"))] | |||
| #[builder(build_method(vis = "pub"))] | |||
There was a problem hiding this comment.
The reason we make TableCommit crate only is that we don't want to allow user to build it manually, all table commits construction should go through transaction api.
…/catalog_sql_update_table
…/catalog_sql_update_table
Li0k
force-pushed
the
li0k/catalog_sql_update_table
branch
from
8dbbf3b to
8d0f168
Compare
|
Hey @liurenjie1024 👋🏻 Small doubt here, I see REST catalog already has this piece of code i.e. update table, is it merged because conflict detection and resolution is enforced by REST catalog itself? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR support
update_tableinterface for sql catalogupdate_tableOther PRs for reference:
After these PRs have been merged, we can use sql database as the catalog backend