fix: return proper error rather than persisting error message on snapshot #1960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shot Signed-off-by: StandingMan <[email protected]>
Contributor
Author
CTTY
suggested changes
Dec 24, 2025
Collaborator
CTTY
left a comment
CTTY
left a comment
There was a problem hiding this comment.
Hi @Standing-Man , thanks for the contribution! Looks good overall, I just have some minor feedbacks
Signed-off-by: StandingMan <[email protected]>
Signed-off-by: StandingMan <[email protected]>
liurenjie1024
approved these changes
Dec 30, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @Standing-Man for this fix, and @CTTY for review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Avoid storing error message on snapshot, return error instead.
Are these changes tested?
Yes