Skip to content

Conversation

@lgingerich
Copy link
Contributor

Which issue does this PR close?

What changes are included in this PR?

  • Add support for ArrowReaderOptions
  • This PR does not actually hook up ArrowReaderOptions to be used anywhere as get_metadata is currently only called from parquet_files_to_data_files() which is marked as dead_code.
    • Given this, it's essentially a no-op change, though fixes a minor issue for future integration with ArrowFileReader.

Are these changes tested?

Tested with existing test suite.

@lgingerich
Copy link
Contributor Author

I've confirmed that the failing CI / Unit Tests passes for me locally (MacOS)

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lgingerich for this pr!

opendal = "0.55.0"
ordered-float = "4"
parquet = "57.0"
parquet = "57.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to change this? We expect to keep parquet version same as arrow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize it initially, but the necessary ParquetMetaDataReader method with_metadata_options did not get added until 57.1.0. You can see the initial clippy failure here: https://github.com/apache/iceberg-rust/actions/runs/20211830111/job/58018793697#step:4:854

Given this, I am fine if you'd prefer to just close this PR for now. I assume upgrading Arrow also isn't a preferred solution for such a minor PR.

Also, sorry for forgetting to update the PR comment with these details!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lgingerich , I prefer to wait for next round upgrading of arrow to add this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support ArrowReaderOptions

2 participants