feat: Add API to set location in the transacation #1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanc-n
reviewed
May 13, 2025
| ); | ||
| } | ||
|
|
||
| #[test] |
Contributor
There was a problem hiding this comment.
Should we make a integration test to make sure SetLocation works after the commit?
Contributor
There was a problem hiding this comment.
I believe we do not have one yet
Collaborator
Author
There was a problem hiding this comment.
I think this makes sense, many transaction APIs lack an integ test to verify them. I've created this issue to track the task of adding this integ test: #1322
liurenjie1024
approved these changes
May 13, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @CTTY for this pr, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
set_locationintransactionAre these changes tested?