Fix predicates not matching the Arrow type of columns read from parquet files #1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdd
previously approved these changes
May 12, 2025
Contributor
sdd
left a comment
sdd
left a comment
There was a problem hiding this comment.
Looks good to me - in fact I think I've also encountered this issue before with data written by pyiceberg, so I'm glad to see it fixed!
Approved, with a couple of minor comments to address
sdd
approved these changes
May 12, 2025
Contributor
|
Approved and merged - thanks for your contribution @phillipleblanc 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
I check the type of the literal scalar against the value we read from the parquet file and convert the literal to match the Parquet Arrow data type.
Are these changes tested?
Tested with a new unit test to cover the different cases.